Should the word teacher be capitalized when referring to French teacher?

Yes, "French teacher" should be capitalized because "French" is an adjective modifying the proper noun "teacher." Think of it as a title: "the French Teacher."